Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 660063: Move skia_utils_gtk.cc/.h to app/gfx/ directory. (Closed)

Created:
10 years, 10 months ago by tfarina (gmail-do not use)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paul Godavari, ben+cc_chromium.org
Visibility:
Public.

Description

Move skia_utils_gtk.cc/.h to app/gfx/ directory. BUG=22853 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40083

Patch Set 1 : '' #

Total comments: 19

Patch Set 2 : fixes comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -134 lines) Patch
M app/app_base.gypi View 1 2 chunks +3 lines, -1 line 0 comments Download
A + app/gfx/skia_utils_gtk.h View 1 chunk +22 lines, -22 lines 0 comments Download
A + app/gfx/skia_utils_gtk.cc View 1 chunk +32 lines, -32 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/settings_page_view.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/download_item_gtk.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D skia/ext/skia_utils_gtk.h View 1 chunk +0 lines, -22 lines 0 comments Download
D skia/ext/skia_utils_gtk.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M skia/skia.gyp View 1 2 chunks +1 line, -3 lines 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_gtk.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/textfield/native_textfield_gtk.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M views/window/dialog_client_view.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina (gmail-do not use)
OK, done the deletion case. I have had to do it with gcl/svn :/ Hum, ...
10 years, 10 months ago (2010-02-25 02:39:21 UTC) #1
Peter Kasting
LGTM after fixing http://codereview.chromium.org/660063/diff/23/1020 File app/app_base.gypi (right): http://codereview.chromium.org/660063/diff/23/1020#newcode1 app/app_base.gypi:1: # Copyright (c) 2009 The Chromium ...
10 years, 10 months ago (2010-02-25 21:48:57 UTC) #2
tfarina (gmail-do not use)
Nits fixed and uploaded another snapshot. -Thiago http://codereview.chromium.org/660063/diff/23/1020 File app/app_base.gypi (right): http://codereview.chromium.org/660063/diff/23/1020#newcode1 app/app_base.gypi:1: # Copyright ...
10 years, 10 months ago (2010-02-25 23:52:17 UTC) #3
Peter Kasting
LGTM, will land
10 years, 10 months ago (2010-02-26 00:36:45 UTC) #4
Peter Kasting
10 years, 10 months ago (2010-02-26 00:48:16 UTC) #5
Landed in r40083.

Powered by Google App Engine
This is Rietveld 408576698