Make SandboxInterfaceInfo somewhat backwards compatible...

Make SandboxInterfaceInfo somewhat backwards compatible

Hack to allow a mismached chrome exe and dll (different versions) to not crash.

The older chrome exe will pass a union, the new chrome dll expects a struct.


BUG=74046
TEST=see bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76108

[cpu_(ooo_6.6-7.5), 2011-02-25 21:24:34]

.

[amit, 2011-02-25 21:31:04]

lgtm

http://codereview.chromium.org/6598013/diff/1/sandbox/src/sandbox_types.h
File sandbox/src/sandbox_types.h (right):

http://codereview.chromium.org/6598013/diff/1/sandbox/src/sandbox_types.h#new...
sandbox/src/sandbox_types.h:62: void* legacy;
nit: why not have the exact same union as 'legacy'? IMO, changes will be more
readable with for e.g.: info->legacy.broker_services.

[cpu_(ooo_6.6-7.5), 2011-02-25 22:18:10]

On 2011/02/25 21:31:04, amit wrote:
> lgtm
> 
> http://codereview.chromium.org/6598013/diff/1/sandbox/src/sandbox_types.h
> File sandbox/src/sandbox_types.h (right):
> 
>
http://codereview.chromium.org/6598013/diff/1/sandbox/src/sandbox_types.h#new...
> sandbox/src/sandbox_types.h:62: void* legacy;
> nit: why not have the exact same union as 'legacy'? IMO, changes will be more
> readable with for e.g.: info->legacy.broker_services.

I wouldn't worry. Its not going to live very long in trunk :)

[rvargas (doing something else), 2011-02-25 22:26:17]

LGTM

http://codereview.chromium.org/6598013/diff/1/chrome/common/sandbox_init_wrap...
File chrome/common/sandbox_init_wrapper_win.cc (right):

http://codereview.chromium.org/6598013/diff/1/chrome/common/sandbox_init_wrap...
chrome/common/sandbox_init_wrapper_win.cc:19: // TODO(cpu): Reomove this nasty
hack after M10 release.
typo

[cpu_(ooo_6.6-7.5), 2011-02-25 22:32:53]

Thanks, for reference the tracking bug for the right fix is

http://code.google.com/p/chromium/issues/detail?id=74210

I will revert from trunk next week.


On 2011/02/25 22:26:17, rvargas wrote:
> LGTM
> 
>
http://codereview.chromium.org/6598013/diff/1/chrome/common/sandbox_init_wrap...
> File chrome/common/sandbox_init_wrapper_win.cc (right):
> 
>
http://codereview.chromium.org/6598013/diff/1/chrome/common/sandbox_init_wrap...
> chrome/common/sandbox_init_wrapper_win.cc:19: // TODO(cpu): Reomove this nasty
> hack after M10 release.
> typo