Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sandbox/src/sandbox_types.h

Issue 6598013: Make SandboxInterfaceInfo somewhat backwards compatible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/sandbox_init_wrapper_win.cc ('K') | « chrome/common/sandbox_init_wrapper_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/src/sandbox_types.h
===================================================================
--- sandbox/src/sandbox_types.h (revision 75565)
+++ sandbox/src/sandbox_types.h (working copy)
@@ -53,10 +53,15 @@
class TargetServices;
class BrokerServices;
-// Contains the pointer to a target or broker service.
+// Contains the pointer to a target or broker service. Older code used
+// a union so the |legacy| member is there for us to detect we are
+// being passed a SandboxInterfaceInfo by old code. If legacy is not
+// null it means we are dealing with old code a must copy this value
+// into both |broker_services| and |target_services|.
struct SandboxInterfaceInfo {
+ void* legacy;
amit 2011/02/25 21:31:04 nit: why not have the exact same union as 'legacy'
+ BrokerServices* broker_services;
TargetServices* target_services;
- BrokerServices* broker_services;
};
#if SANDBOX_EXPORTS
« chrome/common/sandbox_init_wrapper_win.cc ('K') | « chrome/common/sandbox_init_wrapper_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698