Issue 6597001: Modify x86 kernel command line to enable nmi watchog.

Issue 6597001: Modify x86 kernel command line to enable nmi watchog. (Closed)

Created:
9 years, 10 months ago by vb

Modified:
9 years, 6 months ago

Reviewers:
Mandeep Singh Baines, gauravsh

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Modify x86 kernel command line to enable nmi watchog. For the kernel nmi to be activated and function properly it must be enabled in the kernel command line. This CL adds `nmi_watchdog=panic,lapic' (which is equivalent of nmi_watchdog=2) to the command line. The reason '2' was used and not '1' is that nmi_watchdog=1 is known to break audio functionality on chromeos devices. Note that only x86 platforms are affected by this change, ARM platforms will be added later. This CL is required by the autotest CL http://codereview.chromium.org/6596002 Change-Id: Ie8a9ba3f0de6d236cbe098e402b0240aa64ddcd0 BUG=chromium-os:12463, chromium-os:12464 TEST=see below . build new image for test and install it on the target . restart the target . observe the contents of /proc/sys/kernel/nmi_watchdog (it should read '1' after reboot) . run autotest as follows (chroot) ~/trunk/src/scripts $ ./run_remote_tests.sh \ --board=x86-mario --remote=172.22.75.163 \ platform_KernelErrorPaths kernel_BootMessagesServer \ platform_HighResTimers . observe the results: INFO : Test results: --------------------------------------------------------- kernel_BootMessagesServer PASS kernel_BootMessagesServer/kernel_BootMessagesServer PASS coldboot_active_mb 50 coldboot_anonpages_mb 36 coldboot_buffers_mb 3 coldboot_cached_mb 166 coldboot_inactive_mb 156 coldboot_memfree_mb 1649 platform_HighResTimers PASS platform_HighResTimers/platform_HighResTimers PASS platform_KernelErrorPaths PASS platform_KernelErrorPaths/platform_KernelErrorPaths PASS --------------------------------------------------------- Total PASS: 6/6 (100%) No crashes detected during testing. Elapsed time: 4m28s Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8e623f6

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build_kernel_image.sh	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

http://codereview.chromium.org/6597001/diff/1/build_kernel_image.sh File build_kernel_image.sh (right): http://codereview.chromium.org/6597001/diff/1/build_kernel_image.sh#newcode135 build_kernel_image.sh:135: loglevel=7 Nit. This looks like leftover. http://codereview.chromium.org/6597001/diff/1/build_kernel_image.sh#newcode170 build_kernel_image.sh:170: nmi_watchdog=1 ...

9 years, 10 months ago (2011-02-25 18:37:47 UTC) #2

Updated code and cl description, PTAL http://codereview.chromium.org/6597001/diff/1/build_kernel_image.sh File build_kernel_image.sh (right): http://codereview.chromium.org/6597001/diff/1/build_kernel_image.sh#newcode135 build_kernel_image.sh:135: loglevel=7 On 2011/02/25 ...

9 years, 10 months ago (2011-02-26 00:02:11 UTC) #3

ping? On 2011/02/26 00:02:11, vb wrote: > Updated code and cl description, PTAL > > ...

9 years, 9 months ago (2011-02-28 17:26:06 UTC) #4

gauravsh

Does this impact release images? or just test images? On Mon, Feb 28, 2011 at ...

9 years, 9 months ago (2011-02-28 18:40:12 UTC) #6

9 years, 9 months ago (2011-02-28 18:44:56 UTC) #7

On Mon, Feb 28, 2011 at 10:40 AM, Gaurav Shah <gauravsh@chromium.org> wrote:
> Does this impact release images? or just test images?
>

It does impact all images.

cheers,
/v

> On Mon, Feb 28, 2011 at 9:26 AM,  <vbendeb@chromium.org> wrote:
>> ping?
>>
>> On 2011/02/26 00:02:11, vb wrote:
>>>
>>> Updated code and cl description, PTAL
>>
>>> http://codereview.chromium.org/6597001/diff/1/build_kernel_image.sh
>>> File build_kernel_image.sh (right):
>>
>>>
>>>
http://codereview.chromium.org/6597001/diff/1/build_kernel_image.sh#newcode135
>>> build_kernel_image.sh:135: loglevel=7
>>> On 2011/02/25 18:37:47, Mandeep Singh Baines wrote:
>>> > Nit. This looks like leftover.
>>
>>> Done.
>>
>>>
>>>
http://codereview.chromium.org/6597001/diff/1/build_kernel_image.sh#newcode170
>>> build_kernel_image.sh:170: nmi_watchdog=1
>>> On 2011/02/25 18:37:47, Mandeep Singh Baines wrote:
>>> > We tried this and had issues. This should really be nmi_watchdog=2.
>>
>> Actually,
>>>
>>> > instead of 2 use the symbolic 'lapic,panic' as per:
>>> >
>>> >
>>
>>
http://git.chromium.org/gitweb/?p=kernel.git;a=blob;f=Documentation/kernel-pa...
>>>
>>> >
>>> > Please test by running kernel_BootMessagesServer and
>>
>> platform_HighResTimers.
>>>
>>> > Seting nmi_watchdog=1 breaks HighResTimers. It is also heavier weight
>>> > than
>>> > nmi_watchdog=2.
>>
>>> Done.
>>
>>
>>
>> http://codereview.chromium.org/6597001/
>>
>
>
>
> --
> -g
>

Expand Messages | Collapse Messages