Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 6596002: Fix kernel error paths test. (Closed)

Created:
9 years, 10 months ago by vb
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Fix kernel error paths test. This CL modifies the platform_KernelErrorPaths autotest to properly utilize the capabilities provided by the /proc/breakme interface on the target (the source file of this interface can be found in http://git.chromium.org/gitweb/?p=kernel.git;a=blob;f=fs/proc/breakme.c. For nmi watchdog to operate properly, the kernel command line needs to be modified (see http://codereview.chromium.org/6597001) Few of the strings handled by this 'breakme' interface ('deadlock', 'softlockup', and 'irqlockup') do not cause target reset, even though some of them do lock it up. This will have to be investigated and fixed on the kernel side, then the strings could be added to this test. Change-Id: If62b0b0baef9176105ad59ff1ef1dda75a5e17c6 BUG=chromium-os:12463, chromium-os:12464 TEST=see below: == 1 == run in chroot ~/trunk/src/scripts: ./run_remote_tests.sh --board=x86-mario --remote=<target_ip> platform_KernelErrorPaths observe the target reset a few times, watch for INFO : Test results: --------------------------------------------------------- platform_KernelErrorPaths PASS platform_KernelErrorPaths/platform_KernelErrorPaths PASS --------------------------------------------------------- Total PASS: 2/2 (100%) in the end of the output. The test takes 157 seconds to complete. == 2 == . repeat the above test twice, once with no file '/home/chronos/Consent To Send Stats' present on the target and again with the file present and containing some multiline text. After each test run the state and contents of the file are maintained. == It looks like there is a problem with timeout handling by autotest (in cases when the target does not restart, or is not available at the beginning of the test) - this needs to be investigated separately. Another autotest enhancement could be shortening the time it takes to reestablish ssh connection after target restarts. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=643e941

Patch Set 1 : Fix platform_KernelErrorPaths #

Total comments: 3

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -87 lines) Patch
M server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py View 1 1 chunk +64 lines, -87 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vb
9 years, 10 months ago (2011-02-25 18:13:53 UTC) #1
Mandeep Singh Baines
LGTM Next, please add to control.kernel_main_functional
9 years, 10 months ago (2011-02-25 18:24:58 UTC) #2
petkov
http://codereview.chromium.org/6596002/diff/2001/server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py File server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py (right): http://codereview.chromium.org/6596002/diff/2001/server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py#newcode31 server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py:31: def resume_crash_sending(self): who calls this method? it seems it ...
9 years, 10 months ago (2011-02-25 19:54:35 UTC) #3
vb
http://codereview.chromium.org/6596002/diff/2001/server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py File server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py (right): http://codereview.chromium.org/6596002/diff/2001/server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py#newcode31 server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py:31: def resume_crash_sending(self): On 2011/02/25 19:54:35, petkov wrote: > who ...
9 years, 10 months ago (2011-02-25 23:27:37 UTC) #4
petkov
9 years, 9 months ago (2011-02-28 07:18:50 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698