Issue 6594121: Revert 76553 - Applying factory pattern (through NativeMetafileFactory class)...

Issue 6594121: Revert 76553 - Applying factory pattern (through NativeMetafileFactory class)... (Closed)

Created:
9 years, 9 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
dpapad

CC:
chromium-reviews, Paweł Hajdan Jr., jam, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 76553 - Applying factory pattern (through NativeMetafileFactory class). It is used to retrieve different printing contexts (based on the platform and user preferences). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6544028 TBR=dpapad@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76555

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+213 lines, -620 lines)			Patch
M	chrome/browser/printing/print_view_manager.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/common/common_param_traits_unittest.cc	View	2 chunks	+16 lines, -23 lines	0 comments	Download
M	chrome/plugin/webplugin_delegate_stub.cc	View	4 chunks	+8 lines, -14 lines	0 comments	Download
M	chrome/renderer/mock_printer.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_linux.cc	View	6 chunks	+8 lines, -12 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_mac.mm	View	6 chunks	+13 lines, -18 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	4 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/renderer/webplugin_delegate_pepper.cc	View	6 chunks	+20 lines, -20 lines	0 comments	Download
M	chrome/renderer/webplugin_delegate_proxy.cc	View	5 chunks	+5 lines, -11 lines	0 comments	Download
M	chrome/service/service_utility_process_host.cc	View	2 chunks	+5 lines, -9 lines	0 comments	Download
M	chrome/utility/utility_thread.cc	View	3 chunks	+4 lines, -11 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	printing/emf_win.h	View	5 chunks	+21 lines, -33 lines	0 comments	Download
MM	printing/emf_win_unittest.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	printing/image.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	printing/native_metafile.h	View	1 chunk	+36 lines, -5 lines	0 comments	Download
D	printing/native_metafile_factory.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	printing/native_metafile_factory.cc	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	printing/native_metafile_linux.h	View	1 chunk	+0 lines, -81 lines	0 comments	Download
D	printing/native_metafile_mac.h	View	1 chunk	+0 lines, -90 lines	0 comments	Download
D	printing/native_metafile_win.h	View	1 chunk	+0 lines, -103 lines	0 comments	Download
M	printing/pdf_metafile_mac.h	View	4 chunks	+19 lines, -26 lines	0 comments	Download
M	printing/pdf_metafile_mac_unittest.cc	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	printing/pdf_ps_metafile_cairo.h	View	3 chunks	+17 lines, -24 lines	0 comments	Download
M	printing/pdf_ps_metafile_cairo_unittest.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	printing/print_settings_initializer_gtk.cc	View	3 chunks	+14 lines, -14 lines	0 comments	Download
M	printing/printed_document.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	printing/printing.gyp	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	printing/printing_context_cairo.cc	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	4 chunks	+5 lines, -14 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages