chrome/browser/printing/print_view_manager.cc - Issue 6594121: Revert 76553 - Applying factory pattern (through NativeMetafileFactory class)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 6594121: Revert 76553 - Applying factory pattern (through NativeMetafileFactory class)... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_view_manager.cc

===================================================================

--- chrome/browser/printing/print_view_manager.cc (revision 76554)

+++ chrome/browser/printing/print_view_manager.cc (working copy)

@@ -18,7 +18,6 @@

#include "content/browser/tab_contents/navigation_entry.h"

#include "content/browser/tab_contents/tab_contents.h"

#include "grit/generated_resources.h"

-#include "printing/native_metafile_factory.h"

#include "printing/native_metafile.h"

#include "printing/printed_document.h"

#include "ui/base/l10n/l10n_util.h"

@@ -131,7 +130,7 @@

}

- scoped_ptr<NativeMetafile> metafile(NativeMetafileFactory::CreateMetafile());

+ scoped_ptr<NativeMetafile> metafile(new NativeMetafile());

if (metafile_must_be_valid) {

if (!metafile->Init(shared_buf.memory(), params.data_size)) {

NOTREACHED() << "Invalid metafile header";

« no previous file with comments | « no previous file | chrome/common/common_param_traits_unittest.cc » ('j') | no next file with comments »