Issue 6591109: [login_manager] Add stub DBus API for policy get/set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6591109: [login_manager] Add stub DBus API for policy get/set (Closed)

Created:
9 years, 9 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, Chris Masone

Base URL:
http://git.chromium.org/git/login_manager.git@master

Visibility:
Public.

Description

[login_manager] Add stub DBus API for policy get/set Just adding the DBus calls for getting/setting a policy to the session manager. BUG=12670 TEST=build the code; methods do nothing as of yet. Change-Id: I53a5992c813adfda20865ceff583c78a4e56fc51 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a57165a

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -0 lines)			Patch
M	SessionManager.conf	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	interface.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	interface.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	session_manager.xml	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	session_manager_service.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	session_manager_service.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

9 years, 9 months ago (2011-03-02 18:40:53 UTC) #2

LGTM

http://codereview.chromium.org/6591109/diff/1/SessionManager.conf
File SessionManager.conf (right):

http://codereview.chromium.org/6591109/diff/1/SessionManager.conf#newcode69
SessionManager.conf:69: send_member="StorePolicy"/>
take it or leave it: Maybe add full/whole to name?

Expand Messages | Collapse Messages