Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 6591034: Move core pieces of geolocation from chrome to content.... (Closed)

Created:
9 years, 10 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
joth, wyck
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., bulach, John Knottenbelt
Visibility:
Public.

Description

Move core pieces of geolocation from chrome to content. This is a rough carving in some places. i.e. geolocation_permission_context.h needs to split into the interface part and the implementation part. access_token_store.h needs to drop the chrome factory function. arbitrator_dependency_factory.h needs to be split up into the interface and the default implementation. I've left all this to future changes per the other file moves, and since this is already pretty large. TBR=joth Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76228

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : sync #

Patch Set 4 : take out delete of win7_location_provider_unittest_win.cc so patch step works #

Patch Set 5 : add missing files #

Patch Set 6 : fix Linux build #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -9730 lines) Patch
M chrome/browser/extensions/extension_geolocation_apitest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/geolocation/access_token_store.h View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/geolocation/access_token_store.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/access_token_store_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/geolocation/arbitrator_dependency_factories_for_test.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/geolocation/arbitrator_dependency_factories_for_test.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/geolocation/arbitrator_dependency_factory.h View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/geolocation/arbitrator_dependency_factory.cc View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/geolocation/core_location_data_provider_mac.h View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/geolocation/core_location_data_provider_mac.mm View 1 2 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/geolocation/core_location_provider_mac.h View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/geolocation/core_location_provider_mac.mm View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/geolocation/device_data_provider.h View 1 2 1 chunk +0 lines, -402 lines 0 comments Download
D chrome/browser/geolocation/device_data_provider.cc View 1 2 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/geolocation/device_data_provider_unittest.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/geolocation/empty_device_data_provider.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/geolocation/empty_device_data_provider.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/geolocation/fake_access_token_store.h View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/geolocation/fake_access_token_store.cc View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/geolocation/gateway_data_provider_common.h View 1 2 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/geolocation/gateway_data_provider_common.cc View 1 2 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/geolocation/gateway_data_provider_common_unittest.cc View 1 2 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/browser/geolocation/gateway_data_provider_linux.h View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/geolocation/gateway_data_provider_linux.cc View 1 2 1 chunk +0 lines, -227 lines 0 comments Download
D chrome/browser/geolocation/gateway_data_provider_win.h View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/geolocation/gateway_data_provider_win.cc View 1 2 1 chunk +0 lines, -116 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/geolocation/geolocation_content_settings_map.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
D chrome/browser/geolocation/geolocation_dispatcher_host.h View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/geolocation/geolocation_dispatcher_host.cc View 1 2 1 chunk +0 lines, -191 lines 0 comments Download
M chrome/browser/geolocation/geolocation_exceptions_table_model_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/geolocation/geolocation_observer.h View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/geolocation/geolocation_permission_context.h View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 1 2 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/geolocation/geolocation_prefs.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/geolocation/geolocation_provider.h View 1 2 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/geolocation/geolocation_provider.cc View 1 2 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/geolocation/geolocation_provider_unittest.cc View 1 2 1 chunk +0 lines, -152 lines 0 comments Download
MM chrome/browser/geolocation/geolocation_settings_state.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_settings_state.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/geolocation/geolocation_settings_state_unittest.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
D chrome/browser/geolocation/gps_location_provider_linux.h View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/geolocation/gps_location_provider_linux.cc View 1 2 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/geolocation/gps_location_provider_unittest_linux.cc View 1 2 1 chunk +0 lines, -195 lines 0 comments Download
D chrome/browser/geolocation/libgps_2_38_wrapper_linux.cc View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/geolocation/libgps_2_94_wrapper_linux.cc View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/geolocation/libgps_wrapper_linux.h View 1 2 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/geolocation/libgps_wrapper_linux.cc View 1 2 1 chunk +0 lines, -220 lines 0 comments Download
D chrome/browser/geolocation/location_arbitrator.h View 1 2 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/geolocation/location_arbitrator.cc View 1 2 1 chunk +0 lines, -163 lines 0 comments Download
D chrome/browser/geolocation/location_arbitrator_unittest.cc View 1 2 1 chunk +0 lines, -303 lines 0 comments Download
D chrome/browser/geolocation/location_provider.h View 1 2 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/geolocation/location_provider.cc View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/geolocation/mock_location_provider.h View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/geolocation/mock_location_provider.cc View 1 2 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/geolocation/network_location_provider.h View 1 2 1 chunk +0 lines, -145 lines 0 comments Download
D chrome/browser/geolocation/network_location_provider.cc View 1 2 1 chunk +0 lines, -319 lines 0 comments Download
D chrome/browser/geolocation/network_location_provider_unittest.cc View 1 2 1 chunk +0 lines, -781 lines 0 comments Download
D chrome/browser/geolocation/network_location_request.h View 1 2 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/geolocation/network_location_request.cc View 1 2 1 chunk +0 lines, -452 lines 0 comments Download
D chrome/browser/geolocation/osx_wifi.h View 1 2 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_chromeos.h View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_chromeos.cc View 1 2 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_common.h View 1 2 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_common.cc View 1 2 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_common_unittest.cc View 1 2 1 chunk +0 lines, -232 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_common_win.h View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_common_win.cc View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 1 2 1 chunk +0 lines, -162 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_linux.h View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_linux.cc View 1 2 1 chunk +0 lines, -427 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_mac.h View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_mac.cc View 1 2 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_unittest_chromeos.cc View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_unittest_win.cc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_win.h View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/geolocation/wifi_data_provider_win.cc View 1 2 1 chunk +0 lines, -607 lines 0 comments Download
D chrome/browser/geolocation/win7_location_api_unittest_win.cc View 1 2 1 chunk +0 lines, -337 lines 0 comments Download
D chrome/browser/geolocation/win7_location_api_win.h View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/geolocation/win7_location_api_win.cc View 1 2 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/browser/geolocation/win7_location_provider_win.h View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/geolocation/win7_location_provider_win.cc View 1 2 1 chunk +0 lines, -106 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +2 lines, -57 lines 2 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/test/testing_profile.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/geolocation/access_token_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/arbitrator_dependency_factories_for_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/arbitrator_dependency_factories_for_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/arbitrator_dependency_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/arbitrator_dependency_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/core_location_data_provider_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/core_location_data_provider_mac.mm View 1 chunk +4 lines, -3 lines 0 comments Download
A + content/browser/geolocation/core_location_provider_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/core_location_provider_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/geolocation/device_data_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/device_data_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/device_data_provider_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + content/browser/geolocation/empty_device_data_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/empty_device_data_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/fake_access_token_store.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/fake_access_token_store.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/gateway_data_provider_common.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/gateway_data_provider_common.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/gateway_data_provider_common_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + content/browser/geolocation/gateway_data_provider_linux.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + content/browser/geolocation/gateway_data_provider_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/gateway_data_provider_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/gateway_data_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/geolocation/geolocation_dispatcher_host.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/geolocation_dispatcher_host.cc View 2 chunks +7 lines, -12 lines 0 comments Download
A + content/browser/geolocation/geolocation_observer.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + content/browser/geolocation/geolocation_permission_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/geolocation_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/geolocation_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/geolocation/geolocation_provider_unittest.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
A + content/browser/geolocation/gps_location_provider_linux.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/gps_location_provider_linux.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + content/browser/geolocation/gps_location_provider_unittest_linux.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
A + content/browser/geolocation/libgps_2_38_wrapper_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/libgps_2_94_wrapper_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/libgps_wrapper_linux.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/libgps_wrapper_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/location_arbitrator.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/location_arbitrator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/geolocation/location_arbitrator_unittest.cc View 1 chunk +6 lines, -7 lines 0 comments Download
A + content/browser/geolocation/location_provider.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + content/browser/geolocation/location_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/mock_location_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/mock_location_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/network_location_provider.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/geolocation/network_location_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/geolocation/network_location_provider_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + content/browser/geolocation/network_location_request.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + content/browser/geolocation/network_location_request.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/osx_wifi.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_chromeos.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_common_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/wifi_data_provider_linux.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/wifi_data_provider_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_mac.cc View 1 chunk +4 lines, -3 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_unittest_chromeos.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_unittest_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/geolocation/wifi_data_provider_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/win7_location_api_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/win7_location_api_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/geolocation/win7_location_api_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/geolocation/win7_location_provider_unittest_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/geolocation/win7_location_provider_win.h View 2 chunks +5 lines, -7 lines 0 comments Download
A + content/browser/geolocation/win7_location_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 2 chunks +58 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 10 months ago (2011-02-28 06:16:21 UTC) #1
wyck
I realize this is already committed, John, but you should take a moment to configure ...
9 years, 9 months ago (2011-03-04 19:14:59 UTC) #2
jam
9 years, 9 months ago (2011-03-04 19:28:47 UTC) #3
thanks, i'll fix this.  not all editors support this ;)  i think you can
probably add a macro to VS to do it, but that would hit all the lines, even
the ones that i didn't change, and i think that should belong in other
changes.

On Fri, Mar 4, 2011 at 11:14 AM, <wyck@chromium.org> wrote:

> I realize this is already committed, John, but you should take a moment to
> configure your editor to remove trailing whitespace on save so that this
> doesn't
> happen.  Thanks!
>
>
> http://codereview.chromium.org/6591034/diff/408/chrome/chrome_browser.gypi
> File chrome/chrome_browser.gypi (right):
>
>
>
http://codereview.chromium.org/6591034/diff/408/chrome/chrome_browser.gypi#ne...
> chrome/chrome_browser.gypi:1109:
> 'browser/geolocation/geolocation_content_settings_map.h',
> Remove trailing whitespace.
>
>
>
http://codereview.chromium.org/6591034/diff/408/chrome/chrome_browser.gypi#ne...
> chrome/chrome_browser.gypi:1111:
> 'browser/geolocation/geolocation_exceptions_table_model.h',
> Remove trailing whitespace.
>
>
> http://codereview.chromium.org/6591034/
>

Powered by Google App Engine
This is Rietveld 408576698