Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 6588090: Removed GPU plugin.... (Closed)

Created:
9 years, 9 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
apatrick, jam, piman
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Removed GPU plugin. Pepper 3D v2 does not use the GPU plugin. It is integrated with the accelerated compositor. TEST=PPAPI 3D v2 still works, trybots BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76840

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1276 lines) Patch
M chrome/app/chrome_main.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/common/gpu_plugin.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/common/gpu_plugin.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/common/plugin_messages_internal.h View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/plugin/command_buffer_stub.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/plugin/command_buffer_stub.cc View 1 chunk +0 lines, -195 lines 0 comments Download
D chrome/plugin/command_buffer_stub_win.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 5 chunks +0 lines, -49 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.h View 5 chunks +0 lines, -37 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 12 chunks +18 lines, -437 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 2 chunks +0 lines, -39 lines 0 comments Download
D chrome/test/ui/pepper_uitest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_service.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/gpu_plugin/gpu_plugin.h View 1 chunk +0 lines, -31 lines 0 comments Download
D gpu/gpu_plugin/gpu_plugin.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
LGTM. I don't think we use the WebPluginDelegatePepper any more at all, so maybe all ...
9 years, 9 months ago (2011-03-01 22:16:00 UTC) #1
jam
On 2011/03/01 22:16:00, piman wrote: > LGTM. I don't think we use the WebPluginDelegatePepper any ...
9 years, 9 months ago (2011-03-04 05:33:40 UTC) #2
apatrick
Sure, if it's not used anymore.
9 years, 9 months ago (2011-03-04 17:49:17 UTC) #3
apatrick_chromium
On 2011/03/04 05:33:40, John Abd-El-Malek wrote: > On 2011/03/01 22:16:00, piman wrote: > > LGTM. ...
9 years, 9 months ago (2011-03-09 19:25:34 UTC) #4
jam
On Wed, Mar 9, 2011 at 11:25 AM, <apatrick@chromium.org> wrote: > Reviewers: piman, John Abd-El-Malek, ...
9 years, 9 months ago (2011-03-09 20:23:40 UTC) #5
apatrick_chromium
Awesome, I'll keep deleting code then :)
9 years, 9 months ago (2011-03-09 21:52:00 UTC) #6
jam
9 years, 9 months ago (2011-03-09 21:53:42 UTC) #7
great, i really like the cl below!

On Wed, Mar 9, 2011 at 1:52 PM, <apatrick@chromium.org> wrote:

> Awesome, I'll keep deleting code then :)
>
>
> http://codereview.chromium.org/6588090/
>

Powered by Google App Engine
This is Rietveld 408576698