Issue 6588029: Moved creation of GPU command buffer shared memory into the browser process....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6588029: Moved creation of GPU command buffer shared memory into the browser process.... (Closed)

Created:
9 years, 10 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, jam, brettw-cc_chromium.org, darin-cc_chromium.org, apatrick_chromium, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Moved creation of GPU command buffer shared memory into the browser process. This is to allow the GPU process to be sandboxed on all platforms. TEST=try, run WebGL app on win and mac. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76307

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -137 lines)			Patch
M	chrome/common/gpu_messages_internal.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/gpu/gpu_command_buffer_stub.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/gpu/gpu_command_buffer_stub.cc	View	1	2 chunks	+49 lines, -41 lines	0 comments	Download
M	chrome/plugin/command_buffer_stub.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/plugin/command_buffer_stub.cc	View	1	2 chunks	+9 lines, -61 lines	0 comments	Download
M	chrome/renderer/command_buffer_proxy.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/command_buffer_proxy.cc	View	1	1 chunk	+51 lines, -11 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_unittest.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/command_buffer.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/command_buffer_mock.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/command_buffer/service/command_buffer_service.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/command_buffer_service.cc	View	1	2 chunks	+38 lines, -19 lines	0 comments	Download
M	gpu/pgl/command_buffer_pepper.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	gpu/pgl/command_buffer_pepper.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_context_3d_proxy.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

9 years, 9 months ago (2011-02-28 23:24:18 UTC) #2

LGTM. The ownership of the shared memory regions looks correct to me but it
would be good to do a stress test by reloading some WebGL content repeatedly and
ensure the GPU process's size doesn't increase.

Expand Messages | Collapse Messages