Issue 6588: changes to get mac layout tests moving forward. Turn off objc GC and remove a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6588: changes to get mac layout tests moving forward. Turn off objc GC and remove a... (Closed)

Created:
12 years, 2 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

changes to get mac layout tests moving forward. Turn off objc GC and remove asserts in the plugin stub code that throw off the layout tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3026

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	build/common.xcconfig	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	webkit/port/platform/PluginStubsMac.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

12 years, 2 months ago (2008-10-08 18:47:47 UTC) #2

LGTM

http://codereview.chromium.org/6588/diff/1/3
File build/common.xcconfig (right):

http://codereview.chromium.org/6588/diff/1/3#newcode9
Line 9: //GCC_ENABLE_OBJC_GC = supported
I'd just nix this line entirely, we know how to turn it back on if we need it.

Expand Messages | Collapse Messages