Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: webkit/port/platform/PluginStubsMac.cpp

Issue 6588: changes to get mac layout tests moving forward. Turn off objc GC and remove a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.xcconfig ('K') | « build/common.xcconfig ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/platform/PluginStubsMac.cpp
===================================================================
--- webkit/port/platform/PluginStubsMac.cpp (revision 3002)
+++ webkit/port/platform/PluginStubsMac.cpp (working copy)
@@ -23,7 +23,7 @@
};
PluginInfo * PluginInfoStore::createPluginInfoForPluginAtIndex(unsigned) {
- ASSERT_NOT_REACHED();
+ // TODO(pinkerton): don't assert here because that crashes layout tests.
return NULL;
}
@@ -37,7 +37,7 @@
PluginData::PluginData(const Page* page)
: m_page(page) {
- ASSERT_NOT_REACHED();
+ // TODO(pinkerton): don't assert here because that crashes layout tests.
}
PluginData::~PluginData() {
@@ -48,7 +48,7 @@
}
String PluginData::pluginNameForMimeType(const String& mimeType) const {
- ASSERT_NOT_REACHED();
+ // TODO(pinkerton): don't assert here because that crashes layout tests.
return String();
}
« build/common.xcconfig ('K') | « build/common.xcconfig ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698