Issue 6580028: Fix wrong assertion in assembler causing the shell to crash with --code-comme...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6580028: Fix wrong assertion in assembler causing the shell to crash with --code-comme... (Closed)

Created:
9 years, 10 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix wrong assertion in assembler causing the shell to crash with --code-comments. Since writting a code comment can include a pc-jump the assertion should just check that we are greater than or equal to kMinRelocCommentSize (renamed from kRelocCommentSize), not that we are actually equal to. Committed: http://code.google.com/p/v8/source/detail?r=6928

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	src/assembler.h	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	src/assembler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 10 months ago (2011-02-24 10:25:20 UTC) #2

LGTM

http://codereview.chromium.org/6580028/diff/1/src/assembler.h
File src/assembler.h (right):

http://codereview.chromium.org/6580028/diff/1/src/assembler.h#newcode187
src/assembler.h:187: // The minimum size of a comment is equal to tree bytes for
the extra tagged
tree ->three

Expand Messages | Collapse Messages