Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 6580028: Fix wrong assertion in assembler causing the shell to crash with --code-comme... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/assembler.h ('K') | « src/assembler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 Vector<char> copy = Vector<char>::New(length + 1); 120 Vector<char> copy = Vector<char>::New(length + 1);
121 memcpy(copy.start(), builder.Finalize(), copy.length()); 121 memcpy(copy.start(), builder.Finalize(), copy.length());
122 masm()->RecordComment(copy.start()); 122 masm()->RecordComment(copy.start());
123 } 123 }
124 124
125 125
126 bool LCodeGen::GenerateRelocPadding() { 126 bool LCodeGen::GenerateRelocPadding() {
127 int reloc_size = masm()->relocation_writer_size(); 127 int reloc_size = masm()->relocation_writer_size();
128 while (reloc_size < deoptimization_reloc_size.min_size) { 128 while (reloc_size < deoptimization_reloc_size.min_size) {
129 __ RecordComment(RelocInfo::kFillerCommentString, true); 129 __ RecordComment(RelocInfo::kFillerCommentString, true);
130 reloc_size += RelocInfo::kRelocCommentSize; 130 reloc_size += RelocInfo::kMinRelocCommentSize;
131 } 131 }
132 return !is_aborted(); 132 return !is_aborted();
133 } 133 }
134 134
135 135
136 bool LCodeGen::GeneratePrologue() { 136 bool LCodeGen::GeneratePrologue() {
137 ASSERT(is_generating()); 137 ASSERT(is_generating());
138 138
139 #ifdef DEBUG 139 #ifdef DEBUG
140 if (strlen(FLAG_stop_at) > 0 && 140 if (strlen(FLAG_stop_at) > 0 &&
(...skipping 3730 matching lines...) Expand 10 before | Expand all | Expand 10 after
3871 ASSERT(osr_pc_offset_ == -1); 3871 ASSERT(osr_pc_offset_ == -1);
3872 osr_pc_offset_ = masm()->pc_offset(); 3872 osr_pc_offset_ = masm()->pc_offset();
3873 } 3873 }
3874 3874
3875 3875
3876 #undef __ 3876 #undef __
3877 3877
3878 } } // namespace v8::internal 3878 } } // namespace v8::internal
3879 3879
3880 #endif // V8_TARGET_ARCH_IA32 3880 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« src/assembler.h ('K') | « src/assembler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698