chrome/browser/ui/gtk/notifications/balloon_view_gtk.h - Issue 6580024: Merge 75767 - It's not safe to delete the balloon view during MenuDelegate::S...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/notifications/balloon_view_gtk.h

Issue 6580024: Merge 75767 - It's not safe to delete the balloon view during MenuDelegate::S... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/648/src/

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/notifications/balloon_view_gtk.h

===================================================================

--- chrome/browser/ui/gtk/notifications/balloon_view_gtk.h (revision 75847)

+++ chrome/browser/ui/gtk/notifications/balloon_view_gtk.h (working copy)

@@ -63,7 +63,9 @@

// ui::AnimationDelegate interface.

virtual void AnimationProgressed(const ui::Animation* animation);

- // Do the delayed close work.

+ // Do the delayed close work. The balloon and all view components will be

+ // destroyed at this time, so it shouldn't be called while still processing

+ // an event that relies on them.

void DelayedClose(bool by_user);

// The height of the balloon's shelf.

« no previous file with comments | « no previous file | chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc » ('j') | no next file with comments »