Don't access WebPluginInfo array out of bounds in PluginGroup::RemovePlugin.

Don't access WebPluginInfo array out of bounds in PluginGroup::RemovePlugin.

BUG=73893
TEST=PluginGroupTest.MultipleVersions

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75858

[Bernhard Bauer, 2011-02-23 19:46:44]

please review.

[jam, 2011-02-23 19:49:59]

http://codereview.chromium.org/6579004/diff/1/webkit/plugins/npapi/plugin_gro...
File webkit/plugins/npapi/plugin_group.cc (right):

http://codereview.chromium.org/6579004/diff/1/webkit/plugins/npapi/plugin_gro...
webkit/plugins/npapi/plugin_group.cc:251:
web_plugin_infos_.erase(web_plugin_infos_.begin() + i--);
nit: usually i've seen this be done by not having ++i in the for loop, and
incrementing "i" only in the else statement.  i think that's a little easier to
read, and avoids having the size_t value wrap around

[Bernhard Bauer, 2011-02-23 20:03:34]

On 2011/02/23 19:49:59, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/6579004/diff/1/webkit/plugins/npapi/plugin_gro...
> File webkit/plugins/npapi/plugin_group.cc (right):
> 
>
http://codereview.chromium.org/6579004/diff/1/webkit/plugins/npapi/plugin_gro...
> webkit/plugins/npapi/plugin_group.cc:251:
> web_plugin_infos_.erase(web_plugin_infos_.begin() + i--);
> nit: usually i've seen this be done by not having ++i in the for loop, and
> incrementing "i" only in the else statement.  i think that's a little easier
to
> read, and avoids having the size_t value wrap around

Good point. Done.

[jam, 2011-02-23 20:04:49]

lgtm