Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: webkit/plugins/npapi/plugin_group_unittest.cc

Issue 6579004: Don't access WebPluginInfo array out of bounds in PluginGroup::RemovePlugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/plugins/npapi/plugin_group.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/plugins/npapi/plugin_group.h" 5 #include "webkit/plugins/npapi/plugin_group.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/scoped_ptr.h" 10 #include "base/scoped_ptr.h"
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 EXPECT_EQ(kPlugin3043.desc, group->description()); 279 EXPECT_EQ(kPlugin3043.desc, group->description());
280 EXPECT_TRUE(group->IsVulnerable()); 280 EXPECT_TRUE(group->IsVulnerable());
281 281
282 EXPECT_TRUE(group->EnableGroup(false)); 282 EXPECT_TRUE(group->EnableGroup(false));
283 EXPECT_EQ(kPlugin3044.desc, group->description()); 283 EXPECT_EQ(kPlugin3044.desc, group->description());
284 EXPECT_FALSE(group->IsVulnerable()); 284 EXPECT_FALSE(group->IsVulnerable());
285 285
286 EXPECT_TRUE(group->RemovePlugin(kPlugin3044.path)); 286 EXPECT_TRUE(group->RemovePlugin(kPlugin3044.path));
287 EXPECT_EQ(kPlugin3043.desc, group->description()); 287 EXPECT_EQ(kPlugin3043.desc, group->description());
288 EXPECT_TRUE(group->IsVulnerable()); 288 EXPECT_TRUE(group->IsVulnerable());
289
290 EXPECT_TRUE(group->RemovePlugin(kPlugin3043.path));
291 EXPECT_TRUE(group->IsEmpty());
292 EXPECT_EQ(string16(), group->description());
289 } 293 }
290 294
291 } // namespace npapi 295 } // namespace npapi
292 } // namespace webkit 296 } // namespace webkit
OLDNEW
« no previous file with comments | « webkit/plugins/npapi/plugin_group.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698