Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2283)

Unified Diff: build/install-build-deps.sh

Issue 6567002: Linux: change install-build-deps.sh to install gold linker from binutils 2.21... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/install-build-deps.sh
===================================================================
--- build/install-build-deps.sh (revision 75475)
+++ build/install-build-deps.sh (working copy)
@@ -46,9 +46,9 @@
return
fi
- BINUTILS=binutils-2.20.1
+ BINUTILS=binutils-2.21
BINUTILS_URL=http://ftp.gnu.org/gnu/binutils/$BINUTILS.tar.bz2
- BINUTILS_SHA1=fd2ba806e6f3a55cee453cb25c86991b26a75dee
+ BINUTILS_SHA1=ef93235588eb443e4c4a77f229a8d131bccaecc6
test -f $BINUTILS.tar.bz2 || wget $BINUTILS_URL
if test "`sha1sum $BINUTILS.tar.bz2|cut -d' ' -f1`" != "$BINUTILS_SHA1"
@@ -240,11 +240,11 @@
# Some operating systems already ship gold (on recent Debian and
# Ubuntu you can do "apt-get install binutils-gold" to get it), but
# older releases didn't. Additionally, gold 2.20 (included in Ubuntu
-# Lucid) makes binaries that just segfault.
+# Lucid) makes binaries that just segfault, and 2.20.1 does not support
+# --map-whole-files.
# So install from source if we don't have a good version.
case `ld --version` in
-*gold*2.20.1*) ;;
*gold*2.2[1-9]*) ;;
Peter Mayo 2011/02/23 15:46:47 Are we not confident enough to be happy with 2.30
Lei Zhang 2011/02/23 19:58:15 Unlike Chrome, it takes binutils roughly a decade
* )
if test "$do_inst_gold" = ""
@@ -259,7 +259,7 @@
if test "$do_inst_gold" = "1"
then
# If the system provides a good version of gold, just install it.
- if apt-cache show binutils-gold | grep -Eq 'Version: 2.2(0.1|[1-9]*)'; then
+ if apt-cache show binutils-gold | grep -Eq 'Version: 2.2[1-9]*'; then
echo "Installing binutils-gold. Backing up ld as ld.single."
sudo apt-get install binutils-gold
else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698