Linux: change install-build-deps.sh to install gold linker from binutils 2.21...

build/install-build-deps.sh

 #!/bin/bash -e
 
 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to install everything needed to build chromium (well, ideally, anyway)
 # See http://code.google.com/p/chromium/wiki/LinuxBuildInstructions
 # and http://code.google.com/p/chromium/wiki/LinuxBuild64Bit
 
@@ skipping 28 matching lines @@
   # First make sure root can access this directory, as that's tripped
   # up some folks.
   if sudo touch xyz.$$
   then
     sudo rm xyz.$$
   else
     echo root cannot write to the current directory, not installing gold
     return
   fi
 
-  BINUTILS=binutils-2.20.1
+  BINUTILS=binutils-2.21
   BINUTILS_URL=http://ftp.gnu.org/gnu/binutils/$BINUTILS.tar.bz2
-  BINUTILS_SHA1=fd2ba806e6f3a55cee453cb25c86991b26a75dee
+  BINUTILS_SHA1=ef93235588eb443e4c4a77f229a8d131bccaecc6
 
   test -f $BINUTILS.tar.bz2 || wget $BINUTILS_URL
   if test "`sha1sum $BINUTILS.tar.bz2|cut -d' ' -f1`" != "$BINUTILS_SHA1"
   then
     echo Bad sha1sum for $BINUTILS.tar.bz2
     exit 1
   fi
 
   tar -xjvf $BINUTILS.tar.bz2
   cd $BINUTILS
   ./configure --prefix=/usr/local/gold --enable-gold

[Evan Martin, 2011/02/23 19:24:20]

While we're at it, do you mind checking if --enable-threads here works? 
(Resulting binary should not print an error about threads being turned off at
configure time if you run it with --threads.)

[Lei Zhang, 2011/02/23 19:58:15]

2.21 has --threads, but it also has this bug:
http://sourceware.org/bugzilla/show_bug.cgi?id=12316, so we'll need to patch it.
Otherwise gyp will detect --threads support, try to use it, and fail. Patch set
2 coming up in a bit.

   make maybe-all-binutils maybe-all-gold -j4
   if sudo make maybe-install-binutils maybe-install-gold
   then
     # Still need to figure out graceful way of pointing gyp to use
     # /usr/local/gold/bin/ld without requiring him to set environment
     # variables.  That will go into bootstrap-linux.sh when it's ready.
     echo "Installing gold as /usr/bin/ld."
     echo "To uninstall, do 'cd /usr/bin; sudo rm ld; sudo mv ld.orig ld'"
     test -f /usr/bin/ld && test ! -f /usr/bin/ld.orig && \
         sudo mv /usr/bin/ld /usr/bin/ld.orig
@@ skipping 160 matching lines @@
   yes n | $new_list_cmd || true
   echo
   echo "You will have to install the above packages yourself."
   echo
   exit 100
 fi
 
 # Some operating systems already ship gold (on recent Debian and
 # Ubuntu you can do "apt-get install binutils-gold" to get it), but
 # older releases didn't.  Additionally, gold 2.20 (included in Ubuntu
-# Lucid) makes binaries that just segfault.
+# Lucid) makes binaries that just segfault, and 2.20.1 does not support
+# --map-whole-files.
 # So install from source if we don't have a good version.
 
 case `ld --version` in
-*gold*2.20.1*) ;;
 *gold*2.2[1-9]*) ;;

[Peter Mayo, 2011/02/23 15:46:47]

Are we not confident enough to be happy with 2.30 or 3.1?

Still, seems reasonable given a close eye on the pulse of gold.

[Lei Zhang, 2011/02/23 19:58:15]

Unlike Chrome, it takes binutils roughly a decade to hit 2.30. We'll keep an eye
on it. ;)

 * )
   if test "$do_inst_gold" = ""
   then
     echo "Gold is a new linker that links Chrome 5x faster than ld."
     echo "Don't use it if you need to link other apps (e.g. valgrind, wine)"
     echo -n "REPLACE SYSTEM LINKER ld with gold and back up ld? (y/N) "
     if yes_no 1; then
       do_inst_gold=1
     fi
   fi
   if test "$do_inst_gold" = "1"
   then
     # If the system provides a good version of gold, just install it.
-    if apt-cache show binutils-gold | grep -Eq 'Version: 2.2(0.1|[1-9]*)'; then
+    if apt-cache show binutils-gold | grep -Eq 'Version: 2.2[1-9]*'; then
       echo "Installing binutils-gold. Backing up ld as ld.single."
       sudo apt-get install binutils-gold
     else
       # FIXME: avoid installing as /usr/bin/ld
       echo "Building binutils. Backing up ld as ld.orig."
       install_gold || exit 99
     fi
   else
     echo "Not installing gold."
   fi
@@ skipping 176 matching lines @@
              sed -e 's/[.]so[.][0-9].*/.so/' |
              sort -u); do
     [ "x${i##*/}" = "xld-linux.so" ] && continue
     [ -r "$i" ] && continue
     j="$(ls "$i."* | sed -e 's/.*[.]so[.]\([^.]*\)$/\1/;t;d' |
          sort -n | tail -n 1)"
     [ -r "$i.$j" ] || continue
     sudo ln -s "${i##*/}.$j" "$i"
   done
 fi