Linux: change install-build-deps.sh to install gold linker from binutils 2.21...

Linux: change install-build-deps.sh to install gold linker from binutils 2.21.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75790

[Lei Zhang, 2011-02-23 09:57:11]

We're starting to have trouble linking with older version of gold - running into
the 1024 file descriptor limit. One fix is to raise the limit to 65k. On 64-bit
machines, we can just use a newer gold that supports --map-whole-file.

[Lei Zhang, 2011-02-23 09:58:49]

+evan, peter, FYI.

[Michael Moss, 2011-02-23 15:38:06]

LGTM

[Peter Mayo, 2011-02-23 15:46:47]

http://codereview.chromium.org/6567002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/6567002/diff/1/build/install-build-deps.sh#new...
build/install-build-deps.sh:248: *gold*2.2[1-9]*) ;;
Are we not confident enough to be happy with 2.30 or 3.1?

Still, seems reasonable given a close eye on the pulse of gold.

[Evan Martin, 2011-02-23 19:24:20]

LGTM

http://codereview.chromium.org/6567002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/6567002/diff/1/build/install-build-deps.sh#new...
build/install-build-deps.sh:62: ./configure --prefix=/usr/local/gold
--enable-gold
While we're at it, do you mind checking if --enable-threads here works? 
(Resulting binary should not print an error about threads being turned off at
configure time if you run it with --threads.)

[Lei Zhang, 2011-02-23 19:58:15]

http://codereview.chromium.org/6567002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

http://codereview.chromium.org/6567002/diff/1/build/install-build-deps.sh#new...
build/install-build-deps.sh:62: ./configure --prefix=/usr/local/gold
--enable-gold
On 2011/02/23 19:24:20, Evan Martin wrote:
> While we're at it, do you mind checking if --enable-threads here works? 
> (Resulting binary should not print an error about threads being turned off at
> configure time if you run it with --threads.)

2.21 has --threads, but it also has this bug:
http://sourceware.org/bugzilla/show_bug.cgi?id=12316, so we'll need to patch it.
Otherwise gyp will detect --threads support, try to use it, and fail. Patch set
2 coming up in a bit.

http://codereview.chromium.org/6567002/diff/1/build/install-build-deps.sh#new...
build/install-build-deps.sh:248: *gold*2.2[1-9]*) ;;
On 2011/02/23 15:46:47, Peter Mayo wrote:
> Are we not confident enough to be happy with 2.30 or 3.1?
> 
> Still, seems reasonable given a close eye on the pulse of gold.

Unlike Chrome, it takes binutils roughly a decade to hit 2.30. We'll keep an eye
on it. ;)

[Evan Martin, 2011-02-23 20:01:23]

On 2011/02/23 19:58:15, Lei Zhang wrote:
> 2.21 has --threads, but it also has this bug:
> http://sourceware.org/bugzilla/show_bug.cgi?id=12316, so we'll need to patch
it.
> Otherwise gyp will detect --threads support, try to use it, and fail. Patch
set
> 2 coming up in a bit.

Oh, right.  Don't worry about it then.  Larger code = separate patch is ok.

[Lei Zhang, 2011-02-23 21:23:50]

PTAL at patch set 3.

[Evan Martin, 2011-02-23 21:29:36]

LGTM