Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: user_collector.cc

Issue 6559003: Modify crash-reporter to collect crash information for unofficial builds. (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« crash_collector.cc ('K') | « crash_collector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: user_collector.cc
diff --git a/user_collector.cc b/user_collector.cc
index 6e6c76596c649c3a6b696c4f35daeb951c747ab9..a45bd94ea4702596b4d19bab0ad7cec2d2c39c16 100644
--- a/user_collector.cc
+++ b/user_collector.cc
@@ -472,6 +472,12 @@ bool UserCollector::HandleCrash(const std::string &crash_attributes,
logger_->LogWarning("Received crash notification for %s[%d] sig %d (%s)",
exec.c_str(), pid, signal, handling_string);
+ // For unofficial images, we always want to keep the crash reports unless
+ // we're testing the crash facilities themselves.
+ if (!IsOfficialBuild() && !IsCrashTestInProgress()) {
kmixter1 2011/02/23 04:49:02 Instead of IsOfficialBuild - could you use kLeaveC
thieule 2011/02/23 21:03:04 Done.
+ feedback = true;
+ }
+
if (feedback) {
count_crash_function_();
« crash_collector.cc ('K') | « crash_collector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698