Issue 6546079: Merge 75656 - If we switch into ChromeFrame as a result of a redirect then we...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6546079: Merge 75656 - If we switch into ChromeFrame as a result of a redirect then we... (Closed)

Created:
9 years, 10 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/branches/648/src/

Visibility:
Public.

Merge 75656 - If we switch into ChromeFrame as a result of a redirect then we need to navigate chrome to the correct URL to ensure that scripts on the page see the correct URL. This functionality regressed when the protocol sink patch landed. Fix is to read the URL from the ProtData object which wraps the underlying protocol sink, when our active document loads. Removed stale code from the Chromeframe moniker patch which eventually needs to go. Fixes bug http://code.google.com/p/chromium/issues/detail?can=2&q=71860 BUG=71860 TEST=As described in the bug. Review URL: http://codereview.chromium.org/6469103 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75665

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -28 lines)			Patch
M	chrome_frame/bind_context_info.h	View	3 chunks	+4 lines, -16 lines	0 comments	Download
M	chrome_frame/bind_context_info.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome_frame/chrome_active_document.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/protocol_sink_wrap.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome_frame/urlmon_bind_status_callback.cc	View	1 chunk	+4 lines, -9 lines	0 comments	Download
M	chrome_frame/urlmon_url_request.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)