Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 6469103: If we switch into ChromeFrame as a result of a redirect then we need to navig... (Closed)

Created:
9 years, 10 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

If we switch into ChromeFrame as a result of a redirect then we need to navigate chrome to the correct URL to ensure that scripts on the page see the correct URL. This functionality regressed when the protocol sink patch landed. Fix is to read the URL from the ProtData object which wraps the underlying protocol sink, when our active document loads. Removed stale code from the Chromeframe moniker patch which eventually needs to go. Fixes bug http://code.google.com/p/chromium/issues/detail?can=2&q=71860 BUG=71860 TEST=As described in the bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75656

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M chrome_frame/bind_context_info.h View 1 3 chunks +4 lines, -16 lines 0 comments Download
M chrome_frame/bind_context_info.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/protocol_sink_wrap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome_frame/urlmon_bind_status_callback.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
9 years, 10 months ago (2011-02-22 23:05:59 UTC) #1
amit
lg http://codereview.chromium.org/6469103/diff/1/chrome_frame/bind_context_info.cc File chrome_frame/bind_context_info.cc (right): http://codereview.chromium.org/6469103/diff/1/chrome_frame/bind_context_info.cc#newcode84 chrome_frame/bind_context_info.cc:84: scoped_refptr<ProtData> prot_data = get_prot_data(); nit: this can simply ...
9 years, 10 months ago (2011-02-22 23:12:05 UTC) #2
ananta
9 years, 10 months ago (2011-02-22 23:15:49 UTC) #3
http://codereview.chromium.org/6469103/diff/1/chrome_frame/bind_context_info.cc
File chrome_frame/bind_context_info.cc (right):

http://codereview.chromium.org/6469103/diff/1/chrome_frame/bind_context_info....
chrome_frame/bind_context_info.cc:84: scoped_refptr<ProtData> prot_data =
get_prot_data();
On 2011/02/22 23:12:05, amit wrote:
> nit: this can simply be return prot_data_->url(), no need for extra refptr.

Done.

http://codereview.chromium.org/6469103/diff/1/chrome_frame/bind_context_info.h
File chrome_frame/bind_context_info.h (right):

http://codereview.chromium.org/6469103/diff/1/chrome_frame/bind_context_info....
chrome_frame/bind_context_info.h:107: std::wstring url_;
On 2011/02/22 23:12:05, amit wrote:
> OK to remove this now?

Done.

Powered by Google App Engine
This is Rietveld 408576698