Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/browser/dom_ui/web_ui_favicon_source.cc

Issue 6546078: Makes a handful of DataSources not replace the existing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/web_ui_favicon_source.cc
diff --git a/chrome/browser/dom_ui/web_ui_favicon_source.cc b/chrome/browser/dom_ui/web_ui_favicon_source.cc
index f2d7128718b5c77bec1f8b1be20cfc2f4641e4ab..2eeafd4b06ee9a715470a02830f87ec091dbf922 100644
--- a/chrome/browser/dom_ui/web_ui_favicon_source.cc
+++ b/chrome/browser/dom_ui/web_ui_favicon_source.cc
@@ -54,6 +54,12 @@ std::string WebUIFavIconSource::GetMimeType(const std::string&) const {
return "image/png";
}
+bool WebUIFavIconSource::ShouldReplaceExistingSource() const {
+ // Leave the existing DataSource in place, otherwise we'll drop any pending
+ // requests on the floor.
+ return false;
+}
+
void WebUIFavIconSource::OnFavIconDataAvailable(
FaviconService::Handle request_handle,
bool know_favicon,

Powered by Google App Engine
This is Rietveld 408576698