Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 6546078: Makes a handful of DataSources not replace the existing (Closed)

Created:
9 years, 10 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Makes a handful of DataSources not replace the existing DataSource. In the long term all DataSources should do this, but for now I've added a method that does it. I recently added the IsRegistered method thinking registration should look like: if (!contents->profile()->GetChromeURLDataManager()->IsRegistered( SomeSource::kSomeName)) { contents->profile()->GetChromeURLDataManager()->AddDataSource( new SomeSource()); } But this is too tedious. And long term we should make all sources replace the existing one. BUG=52022 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75752

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -21 lines) Patch
M chrome/browser/dom_ui/new_tab_ui.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/web_ui_favicon_source.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/web_ui_favicon_source.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/web_ui_theme_source.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/web_ui_theme_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_restore_uitest.cc View 1 chunk +1 line, -3 lines 2 comments Download
M chrome/browser/webui/chrome_url_data_manager.h View 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/webui/chrome_url_data_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/webui/chrome_url_data_manager_backend.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
9 years, 10 months ago (2011-02-22 23:35:23 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/6546078/diff/1/chrome/browser/sessions/session_restore_uitest.cc File chrome/browser/sessions/session_restore_uitest.cc (right): http://codereview.chromium.org/6546078/diff/1/chrome/browser/sessions/session_restore_uitest.cc#newcode453 chrome/browser/sessions/session_restore_uitest.cc:453: TEST_F(SessionRestoreUITest, ShareProcessesOnRestore) { Did you mean to include ...
9 years, 10 months ago (2011-02-23 00:17:32 UTC) #2
sky
9 years, 10 months ago (2011-02-23 00:38:57 UTC) #3
http://codereview.chromium.org/6546078/diff/1/chrome/browser/sessions/session...
File chrome/browser/sessions/session_restore_uitest.cc (right):

http://codereview.chromium.org/6546078/diff/1/chrome/browser/sessions/session...
chrome/browser/sessions/session_restore_uitest.cc:453:
TEST_F(SessionRestoreUITest, ShareProcessesOnRestore) {
On 2011/02/23 00:17:32, Evan Martin wrote:
> Did you mean to include this?

Yes. All the changes I've done to ChromeURLDataManager (and URLRequest,
ProcessIterator, process launcher and automation classes) are so this test isn't
flakey! Yowza!

Powered by Google App Engine
This is Rietveld 408576698