Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 6546006: Revert 75306 - Force native frames to repaint when OnNCActivate is called. Wi... (Closed)

Created:
9 years, 10 months ago by mattm
Modified:
9 years, 7 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 75306 - Force native frames to repaint when OnNCActivate is called. With a profile menu button added to the GlassBrowserFrameView, failure to trigger the frame repaint means that the button will remain in the active state even when the frame has been deactivated. DesktopNotification tests failing on win full - speculative revert since this is the only CL in the range that seems possibly related. BUG=none TEST=frames behave normally in Aero mode, when activated and deactivated. Review URL: http://codereview.chromium.org/6507044 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M views/window/window_win.cc View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mattm
9 years, 10 months ago (2011-02-18 01:38:28 UTC) #1
mattm
9 years, 10 months ago (2011-02-18 02:49:34 UTC) #2
Revert had no effect.  You can re-land at your convenience, sorry for the
trouble.

Powered by Google App Engine
This is Rietveld 408576698