Issue 6507044: Force native frames to repaint when OnNCActivate is called. With a profile me...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6507044: Force native frames to repaint when OnNCActivate is called. With a profile me... (Closed)

Created:
9 years, 10 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
beng (no_code_reviews), Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Force native frames to repaint when OnNCActivate is called. With a profile menu button added to the GlassBrowserFrameView, failure to trigger the frame repaint means that the button will remain in the active state even when the frame has been deactivated. BUG=none TEST=frames behave normally in Aero mode, when activated and deactivated. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75306

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -12 lines)			Patch
	M	views/window/window_win.cc	View	1	1 chunk	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 10 months ago (2011-02-17 17:22:09 UTC) #2

LGTM

http://codereview.chromium.org/6507044/diff/1/views/window/window_win.cc
File views/window/window_win.cc (right):

http://codereview.chromium.org/6507044/diff/1/views/window/window_win.cc#newc...
views/window/window_win.cc:860: // displayed.
Please rewrite the last sentence as:

Both the native and non-native frames may render activation-state dependent UI.

Expand Messages | Collapse Messages