chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 6544023: Fix crashes in ExtensionService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 6544023: Fix crashes in ExtensionService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comment/TODO Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index dc6f91e33537c01f15e39f437419668328b56a61..8d73340bff08d63d7a95fea9b663f3457f3bae09 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -120,7 +120,10 @@ const CGFloat kBookmarkBarOverlap = 3.0;

const NSTimeInterval kBookmarkBarAnimationDuration = 0.12;

void RecordAppLaunch(Profile* profile, GURL url) {

- if (!profile->GetExtensionService()->IsInstalledApp(url))

+ // TODO: the ExtensionService should never be NULL, but in some cases it is,

+ // see bug 73768. After it is resolved, the explicit test can go away.

+ ExtensionService* service = profile->GetExtensionService();

+ if (!service || !service->IsInstalledApp(url))

return;

UMA_HISTOGRAM_ENUMERATION(extension_misc::kAppLaunchHistogram,

« no previous file with comments | « chrome/browser/ui/browser_init.cc ('k') | chrome/browser/ui/gtk/bookmark_bar_gtk.cc » ('j') | no next file with comments »