chrome/browser/ui/browser_init.cc - Issue 6544023: Fix crashes in ExtensionService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_init.cc

Issue 6544023: Fix crashes in ExtensionService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comment/TODO Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_init.cc

diff --git a/chrome/browser/ui/browser_init.cc b/chrome/browser/ui/browser_init.cc

index 30cc3afed695997ffa3b82a5cc9b6be6c4d72e95..2d3047c988d52f26922352936301b7f7b121c2d8 100644

--- a/chrome/browser/ui/browser_init.cc

+++ b/chrome/browser/ui/browser_init.cc

@@ -457,7 +457,11 @@ void RecordAppLaunches(

Profile* profile,

const std::vector<GURL>& cmd_line_urls,

const std::vector<BrowserInit::LaunchWithProfile::Tab>& autolaunch_tabs) {

+ // TODO: the ExtensionService should never be NULL, but in some cases it is,

+ // see bug 73768. After it is resolved, the explicit test can go away.

ExtensionService* extension_service = profile->GetExtensionService();

+ if (!extension_service)

+ return;

for (size_t i = 0; i < cmd_line_urls.size(); ++i) {

if (extension_service->IsInstalledApp(cmd_line_urls.at(i))) {