Issue 6544020: Correct browser action popup regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6544020: Correct browser action popup regression (Closed)

Created:
9 years, 10 months ago by Jeff Timanus

Modified:
9 years, 7 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Correct the screen-space positioning of browser-action popup dialogs. Regression was introduced in CL http://codereview.chromium.org/6334101 BUG=73353 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75454

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/ui/views/extensions/extension_popup.cc	View	1	2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jeff Timanus

Rafael, please take a look. When removing my popup code, I removed the logic that ...

9 years, 10 months ago (2011-02-18 20:53:32 UTC) #1

rafaelw

lgtm http://codereview.chromium.org/6544020/diff/1/chrome/browser/ui/views/extensions/extension_popup.cc File chrome/browser/ui/views/extensions/extension_popup.cc (right): http://codereview.chromium.org/6544020/diff/1/chrome/browser/ui/views/extensions/extension_popup.cc#newcode160 chrome/browser/ui/views/extensions/extension_popup.cc:160: // screen coordinates for use placing the popup ...

9 years, 10 months ago (2011-02-18 22:13:21 UTC) #2