Correct browser action popup regression

chrome/browser/ui/views/extensions/extension_popup.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_popup.h"
 
 #include <vector>
 
 #include "chrome/browser/debugger/devtools_manager.h"
 #include "chrome/browser/debugger/devtools_toggle_action.h"
@@ skipping 138 matching lines @@
   // Show the border first, then the popup overlaid on top.
   border_widget_->Show();
   BrowserBubble::Show(activate);
 }
 
 void ExtensionPopup::ResizeToView() {
   // We'll be sizing ourselves to this size shortly, but wait until we
   // know our position to do it.
   gfx::Size new_size = view()->size();
 
+  // |relative_to_| is in browser-relative coordinates, so convert it to
+  // screen coordinates for use placing the popup widgets.

[rafaelw, 2011/02/18 22:13:22]

for use in placing

[Jeff Timanus, 2011/02/18 22:23:35]

Done.

+  gfx::Rect relative_rect = relative_to_;
+  gfx::Point relative_origin = relative_rect.origin();
+  views::View::ConvertPointToScreen(frame_->GetRootView(), &relative_origin);
+  relative_rect.set_origin(relative_origin);
+
   // The rounded corners cut off more of the view than the border insets claim.
   // Since we can't clip the ExtensionView's corners, we need to increase the
   // inset by half the corner radius as well as lying about the size of the
   // contents size to compensate.
   int corner_inset = BubbleBorder::GetCornerRadius() / 2;
   gfx::Size adjusted_size = new_size;
   adjusted_size.Enlarge(2 * corner_inset, 2 * corner_inset);
-  gfx::Rect rect = border_->GetBounds(relative_to_, adjusted_size);
+  gfx::Rect rect = border_->GetBounds(relative_rect, adjusted_size);
   border_widget_->SetBounds(rect);
 
   // Now calculate the inner bounds.  This is a bit more convoluted than
   // it should be because BrowserBubble coordinates are in Browser coordinates
   // while |rect| is in screen coordinates.
   gfx::Insets border_insets;
   border_->GetInsets(&border_insets);
   gfx::Point origin = rect.origin();
   views::View::ConvertPointToView(NULL, frame_->GetRootView(), &origin);
 
@@ skipping 124 matching lines @@
   if (closing_)
     return;
   closing_ = true;
   DetachFromBrowser();
 
   if (observer_)
     observer_->ExtensionPopupIsClosing(this);
 
   Release();  // Balanced in ctor.
 }