Issue 6544015: Call method CheckTitle to verify title of the active tab....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6544015: Call method CheckTitle to verify title of the active tab.... (Closed)

Created:
9 years, 10 months ago by Johnny(Jianning) Ding

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade, Paweł Hajdan Jr.

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Call method CheckTitle to verify title of the active tab. After opening a new tab, the tab may not be ready to read the title. The method CheckTitle checks title within the certain timeout. It may not a good solution but workable and existing code already uses it, so I think we use it to fix this bug. BUG=46781 TEST=UnloadTest.BrowserCloseBeforeUnloadOK. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75386

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/unload_uitest.cc	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM with a comment. http://codereview.chromium.org/6544015/diff/1/chrome/browser/unload_uitest.cc File chrome/browser/unload_uitest.cc (right): http://codereview.chromium.org/6544015/diff/1/chrome/browser/unload_uitest.cc#newcode417 chrome/browser/unload_uitest.cc:417: // Flaky on Linux under ...

9 years, 10 months ago (2011-02-18 12:12:24 UTC) #2

Johnny(Jianning) Ding

9 years, 10 months ago (2011-02-18 13:23:17 UTC) #3

http://codereview.chromium.org/6544015/diff/1/chrome/browser/unload_uitest.cc
File chrome/browser/unload_uitest.cc (right):

http://codereview.chromium.org/6544015/diff/1/chrome/browser/unload_uitest.cc...
chrome/browser/unload_uitest.cc:417: // Flaky on Linux under valgrind.
http://crbug.com/46781
On 2011/02/18 12:12:24, Paweł Hajdan Jr. wrote:
> nit: This comment is now outdated.

Done.

Expand Messages | Collapse Messages