Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: chrome/browser/unload_uitest.cc

Issue 6544015: Call method CheckTitle to verify title of the active tab.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/unload_uitest.cc
===================================================================
--- chrome/browser/unload_uitest.cc (revision 75076)
+++ chrome/browser/unload_uitest.cc (working copy)
@@ -414,10 +414,8 @@
#define MAYBE_BrowserCloseTabWhenOtherTabHasListener \
DISABLED_BrowserCloseTabWhenOtherTabHasListener
#else
-// Flaky on Linux under valgrind. http://crbug.com/46781
-// TODO(stuartmorgan): Switch to just disabling for valgrind.
#define MAYBE_BrowserCloseTabWhenOtherTabHasListener \
- FLAKY_BrowserCloseTabWhenOtherTabHasListener
+ BrowserCloseTabWhenOtherTabHasListener
#endif
// Tests that if there's a renderer process with two tabs, one of which has an
@@ -440,11 +438,9 @@
ui::EF_LEFT_BUTTON_DOWN));
ASSERT_TRUE(browser->WaitForTabCountToBecome(2));
+ CheckTitle(L"popup");
scoped_refptr<TabProxy> popup_tab(browser->GetActiveTab());
ASSERT_TRUE(popup_tab.get());
- std::wstring popup_title;
- EXPECT_TRUE(popup_tab->GetTabTitle(&popup_title));
- EXPECT_EQ(std::wstring(L"popup"), popup_title);
EXPECT_TRUE(popup_tab->Close(true));
ASSERT_TRUE(browser->WaitForTabCountToBecome(1));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698