src/platform-win32.cc - Issue 6543039: Bug: OS::MemoryMappedFile::open() should not truncate a pre-existing file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform-win32.cc

Issue 6543039: Bug: OS::MemoryMappedFile::open() should not truncate a pre-existing file. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/platform-win32.cc

===================================================================

--- src/platform-win32.cc (revision 6868)

+++ src/platform-win32.cc (working copy)

@@ -939,7 +939,7 @@

// Open a physical file

HANDLE file = CreateFileA(name, GENERIC_READ | GENERIC_WRITE,

FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_EXISTING, 0, NULL);

- if (file == NULL) return NULL;

+ if (file == INVALID_HANDLE_VALUE) return NULL;

int size = static_cast<int>(GetFileSize(file, NULL));

« src/platform-freebsd.cc ('K') | « src/platform-solaris.cc ('k') | no next file » | no next file with comments »