src/platform-freebsd.cc - Issue 6543039: Bug: OS::MemoryMappedFile::open() should not truncate a pre-existing file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform-freebsd.cc

Issue 6543039: Bug: OS::MemoryMappedFile::open() should not truncate a pre-existing file. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/platform-freebsd.cc

===================================================================

--- src/platform-freebsd.cc (revision 6868)

+++ src/platform-freebsd.cc (working copy)

@@ -224,7 +224,7 @@

OS::MemoryMappedFile* OS::MemoryMappedFile::open(const char* name) {

- FILE* file = fopen(name, "w+");

+ FILE* file = fopen(name, "a+");

if (file == NULL) return NULL;

fseek(file, 0, SEEK_END);

@@ -238,7 +238,7 @@

OS::MemoryMappedFile* OS::MemoryMappedFile::create(const char* name, int size,

void* initial) {

- FILE* file = fopen(name, "w+");

+ FILE* file = fopen(name, "r+");

mnaganov (inactive) 2011/02/21 17:10:05 Looks like you've changed this in a wrong place.

if (file == NULL) return NULL;

int result = fwrite(initial, size, 1, file);

if (result < 1) {

« no previous file with comments | « src/platform-cygwin.cc ('k') | src/platform-linux.cc » ('j') | no next file with comments »