Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 6542060: X64: Refactor the string add in the type recording binary operation stub... (Closed)

Created:
9 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

X64: Refactor the string add in the type recording binary operation stub This makes the code have the same structore as on IA32 and ARM, and will also support possible fast adding a smi and string where the string is to the right and fast adding of String objects. Committed: http://code.google.com/p/v8/source/detail?r=6892

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -60 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +18 lines, -7 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 6 chunks +94 lines, -50 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 10 months ago (2011-02-22 12:06:10 UTC) #1
William Hesse
9 years, 10 months ago (2011-02-22 12:21:23 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698