src/ia32/code-stubs-ia32.cc - Issue 6542060: X64: Refactor the string add in the type recording binary operation stub...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 6542060: X64: Refactor the string add in the type recording binary operation stub... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/code-stubs-ia32.cc

===================================================================

--- src/ia32/code-stubs-ia32.cc (revision 6881)

+++ src/ia32/code-stubs-ia32.cc (working copy)

@@ -2385,14 +2385,14 @@

void TypeRecordingBinaryOpStub::GenerateAddStrings(MacroAssembler* masm) {

- NearLabel call_runtime;

+ ASSERT(op_ == Token::ADD);

+ NearLabel left_not_string, call_runtime;

// Registers containing left and right operands respectively.

// Test if left operand is a string.

- NearLabel left_not_string;

__ test(left, Immediate(kSmiTagMask));

__ j(zero, &left_not_string);

__ CmpObjectType(left, FIRST_NONSTRING_TYPE, ecx);

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/x64/code-stubs-x64.h » ('j') | no next file with comments »