Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 6542025: Fix command handler for /session/:sessionId/execute (execute_script) for (Closed)

Created:
9 years, 10 months ago by kkania
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix command handler for /session/:sessionId/execute (execute_script) for ChromeDriver. The args parameter should be a ListValue, not a string. Also, the args parameter is not optional; if no args are provided in the request, an error should be returned (the handler was defaulting to an empty list). Patch by jleyba@chromium.org. Original review at http://codereview.chromium.org/6544003 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -69 lines) Patch
M chrome/test/webdriver/WEBDRIVER_TESTS View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/test/webdriver/commands/execute_command.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/webdriver/commands/execute_command.cc View 2 chunks +16 lines, -53 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698