The command handler for /session/:sessionId/execute (execute_script) was...

The command handler for /session/:sessionId/execute (execute_script) was
implemented incorrectly: the "args" JSON parameter should be a ListValue, not
a StringValue. Also, the "args" parameter is not optional; if no "args" are
provided in the request, an error should be returned (the handler was
defaulting to an empty list).

[kkania, 2011-02-17 23:37:47]

LGTM

http://codereview.chromium.org/6544003/diff/1/chrome/test/webdriver/commands/...
File chrome/test/webdriver/commands/execute_command.cc (right):

http://codereview.chromium.org/6544003/diff/1/chrome/test/webdriver/commands/...
chrome/test/webdriver/commands/execute_command.cc:9: #include "base/values.h"
since you're fixing up headers, how about add one for response, error_codes, and
session?

http://codereview.chromium.org/6544003/diff/1/chrome/test/webdriver/commands/...
chrome/test/webdriver/commands/execute_command.cc:29: if
(!GetStringParameter(kScript, &script_)) {
Can you move the parsing of the JSON params out of Init and into ExecutePost?

This would allow you to get rid of the member variables and the custom init

[Jason Leyba, 2011-02-18 00:08:00]

http://codereview.chromium.org/6544003/diff/1/chrome/test/webdriver/commands/...
File chrome/test/webdriver/commands/execute_command.cc (right):

http://codereview.chromium.org/6544003/diff/1/chrome/test/webdriver/commands/...
chrome/test/webdriver/commands/execute_command.cc:9: #include "base/values.h"
On 2011/02/17 23:37:47, kkania wrote:
> since you're fixing up headers, how about add one for response, error_codes,
and
> session?

Done.

http://codereview.chromium.org/6544003/diff/1/chrome/test/webdriver/commands/...
chrome/test/webdriver/commands/execute_command.cc:29: if
(!GetStringParameter(kScript, &script_)) {
On 2011/02/17 23:37:47, kkania wrote:
> Can you move the parsing of the JSON params out of Init and into ExecutePost?
> 
> This would allow you to get rid of the member variables and the custom init

Done.