Issue 6541037: Revert 75444 - Move MockFFmpeg instance setting into the constructor/destruct...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6541037: Revert 75444 - Move MockFFmpeg instance setting into the constructor/destruct... (Closed)

Created:
9 years, 10 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell GONE FROM CHROMIUM, annacc, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 75444 - Move MockFFmpeg instance setting into the constructor/destructor. Previously tests had to manually call MockFFmpeg::set() during test setup and teardown. Now that operation is handled automatically via scoping. BUG=72933 TEST=media_unittests Review URL: http://codereview.chromium.org/6539021 TBR=scherkus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75448

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+196 lines, -106 lines)			Patch
M	media/base/mock_ffmpeg.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	media/base/mock_ffmpeg.cc	View	7 chunks	+49 lines, -37 lines	0 comments	Download
M	media/filters/bitstream_converter_unittest.cc	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View	13 chunks	+51 lines, -45 lines	0 comments	Download
M	media/filters/ffmpeg_glue_unittest.cc	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_h264_bitstream_converter_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	media/media.gyp	View	1 chunk	+47 lines, -0 lines	0 comments	Download
M	media/video/ffmpeg_video_decode_engine_unittest.cc	View	6 chunks	+22 lines, -18 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages