Issue 6539021: Move MockFFmpeg instance setting into the constructor/destructor.

Issue 6539021: Move MockFFmpeg instance setting into the constructor/destructor. (Closed)

Created:
9 years, 10 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move MockFFmpeg instance setting into the constructor/destructor. Previously tests had to manually call MockFFmpeg::set() during test setup and teardown. Now that operation is handled automatically via scoping. BUG=72933 TEST=media_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75444

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -188 lines)			Patch
M	media/base/mock_ffmpeg.h	View	1 2 3 4	2 chunks	+2 lines, -3 lines	0 comments	Download
M	media/base/mock_ffmpeg.cc	View	1 2 3 4	7 chunks	+34 lines, -41 lines	0 comments	Download
M	media/filters/bitstream_converter_unittest.cc	View	1 2 3 4 5	3 chunks	+2 lines, -8 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View	1 2	13 chunks	+45 lines, -51 lines	0 comments	Download
M	media/filters/ffmpeg_glue_unittest.cc	View	1 2 3 4 5	3 chunks	+2 lines, -9 lines	0 comments	Download
M	media/filters/ffmpeg_h264_bitstream_converter_unittest.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View	1 2	2 chunks	+0 lines, -6 lines	0 comments	Download
M	media/media.gyp	View		1 chunk	+0 lines, -47 lines	0 comments	Download
M	media/video/ffmpeg_video_decode_engine_unittest.cc	View	1 2 3 4 5	6 chunks	+18 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

I'm still investigating whether there is an underlying issue at hand here although this does ...

9 years, 10 months ago (2011-02-17 19:15:15 UTC) #1

acolwell GONE FROM CHROMIUM

LGTM http://codereview.chromium.org/6539021/diff/8001/media/filters/ffmpeg_glue_unittest.cc File media/filters/ffmpeg_glue_unittest.cc (right): http://codereview.chromium.org/6539021/diff/8001/media/filters/ffmpeg_glue_unittest.cc#newcode50 media/filters/ffmpeg_glue_unittest.cc:50: virtual void TearDown() {} Can we remove this?

9 years, 10 months ago (2011-02-18 00:41:55 UTC) #3

scherkus (not reviewing)

9 years, 10 months ago (2011-02-18 20:48:12 UTC) #4

http://codereview.chromium.org/6539021/diff/8001/media/filters/ffmpeg_glue_un...
File media/filters/ffmpeg_glue_unittest.cc (right):

http://codereview.chromium.org/6539021/diff/8001/media/filters/ffmpeg_glue_un...
media/filters/ffmpeg_glue_unittest.cc:50: virtual void TearDown() {}
On 2011/02/18 00:41:55, acolwell wrote:
> Can we remove this?

Sure can!

Expand Messages | Collapse Messages