Issue 654009: Deprecate GetDirectoryFromPath on non-Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 654009: Deprecate GetDirectoryFromPath on non-Windows. (Closed)

Created:
10 years, 10 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, John Grabowski

Visibility:
Public.

Description

Deprecate GetDirectoryFromPath on non-Windows. Due to a bunch of changes I made last week, we now only need this in Windows-specific codepaths. BUG=24672 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39715

Patch Set 1 #

Patch Set 2 : ok #

Total comments: 1

Patch Set 3 : with comment #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -23 lines)			Patch
M	base/file_util.h	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	base/file_util_deprecated.h	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	base/file_util_posix.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	base/file_util_unittest.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

http://codereview.chromium.org/654009/diff/10/1002 File base/file_util_deprecated.h (right): http://codereview.chromium.org/654009/diff/10/1002#newcode67 base/file_util_deprecated.h:67: // path == "C:\Windows\system32", returns "C:\Windows" can you please ...

10 years, 10 months ago (2010-02-23 12:37:46 UTC) #3

jochen (gone - plz use gerrit)

10 years, 10 months ago (2010-02-23 12:51:05 UTC) #5

LGTM


On 2010/02/23 12:46:00, Evan Martin wrote:
> ok, added

Expand Messages | Collapse Messages