Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: base/file_util_unittest.cc

Issue 654009: Deprecate GetDirectoryFromPath on non-Windows. (Closed)
Patch Set: with comment Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_util_posix.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_unittest.cc
diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc
index 31bb46fe42a208209e02f9024ef7b2d93cb11c7c..ae6560dc7b45203236baadeda032a7ec5e6a6331 100644
--- a/base/file_util_unittest.cc
+++ b/base/file_util_unittest.cc
@@ -311,6 +311,8 @@ static const struct dir_case {
#endif
};
+#if defined(OS_WIN)
+// This function is deprecated, and only exists on Windows anymore.
TEST_F(FileUtilTest, GetDirectoryFromPath) {
for (unsigned int i = 0; i < arraysize(dir_cases); ++i) {
const dir_case& dir = dir_cases[i];
@@ -319,6 +321,7 @@ TEST_F(FileUtilTest, GetDirectoryFromPath) {
EXPECT_EQ(dir.directory, parent);
}
}
+#endif
TEST_F(FileUtilTest, CountFilesCreatedAfter) {
// Create old file (that we don't want to count)
« no previous file with comments | « base/file_util_posix.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698