chrome/browser/autofill/autofill_manager.cc - Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 6539002: Begun the DCHECK() cleanup. Starting off with /src/chrome/a* and /src/chrome/... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_edit_view_win.cc ('K') | « chrome/browser/autofill/autofill_dialog_controller_mac.mm ('k') | chrome/browser/autofill/contact_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_manager.cc

===================================================================

--- chrome/browser/autofill/autofill_manager.cc (revision 75286)

+++ chrome/browser/autofill/autofill_manager.cc (working copy)

@@ -452,10 +452,10 @@

if ((*iter) == field) {

AutoFillType autofill_type(autofill_field->type());

if (profile) {

- DCHECK(autofill_type.group() != AutoFillType::CREDIT_CARD);

+ DCHECK_NE(autofill_type.group(), AutoFillType::CREDIT_CARD);

FillFormField(profile, autofill_type, &(*iter));

} else {

- DCHECK(autofill_type.group() == AutoFillType::CREDIT_CARD);

+ DCHECK_EQ(autofill_type.group(), AutoFillType::CREDIT_CARD);

FillCreditCardFormField(credit_card, autofill_type, &(*iter));

}

break;

@@ -491,10 +491,10 @@

AutoFillType autofill_type(form_structure->field(k)->type());

if (autofill_type.group() != AutoFillType::NO_GROUP) {

if (profile) {

- DCHECK(autofill_type.group() != AutoFillType::CREDIT_CARD);

+ DCHECK_NE(autofill_type.group(), AutoFillType::CREDIT_CARD);

FillFormField(profile, autofill_type, &result.fields[j]);

} else {

- DCHECK(autofill_type.group() == AutoFillType::CREDIT_CARD);

+ DCHECK_EQ(autofill_type.group(), AutoFillType::CREDIT_CARD);

FillCreditCardFormField(credit_card, autofill_type, &result.fields[j]);

}

@@ -873,7 +873,7 @@

AutoFillType type,

webkit_glue::FormField* field) {

DCHECK(credit_card);

- DCHECK(type.group() == AutoFillType::CREDIT_CARD);

+ DCHECK_EQ(type.group(), AutoFillType::CREDIT_CARD);

DCHECK(field);

if (field->form_control_type() == ASCIIToUTF16("select-one")) {

@@ -898,7 +898,7 @@

AutoFillType type,

webkit_glue::FormField* field) {

DCHECK(profile);

- DCHECK(type.group() != AutoFillType::CREDIT_CARD);

+ DCHECK_NE(type.group(), AutoFillType::CREDIT_CARD);

DCHECK(field);

if (type.subgroup() == AutoFillType::PHONE_NUMBER) {