Issue 6538048: Cleanup PrintWebViewHelper.

Issue 6538048: Cleanup PrintWebViewHelper. (Closed)

Created:
9 years, 10 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
kmadhusu

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup PrintWebViewHelper. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75474

Patch Set 2 : do not change metafile_data_handle #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -36 lines)			Patch
M	chrome/renderer/print_web_view_helper.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_mac.mm	View		3 chunks	+6 lines, -25 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	1	3 chunks	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

- remove unneeded includes / using statements. - remove variables that are only used in ...

9 years, 10 months ago (2011-02-18 06:55:33 UTC) #1

Lei Zhang

On 2011/02/18 06:55:33, Lei Zhang wrote: http://codereview.chromium.org/6538048/diff/1/chrome/renderer/print_web_view_helper_win.cc > File chrome/renderer/print_web_view_helper_win.cc (left): > > http://codereview.chromium.org/6538048/diff/1/chrome/renderer/print_web_view_helper_win.cc#oldcode95 > ...

9 years, 10 months ago (2011-02-18 20:54:22 UTC) #2

kmadhusu

9 years, 10 months ago (2011-02-18 22:48:57 UTC) #3

LGTM.

On 2011/02/18 20:54:22, Lei Zhang wrote:
> On 2011/02/18 06:55:33, Lei Zhang wrote:
>
http://codereview.chromium.org/6538048/diff/1/chrome/renderer/print_web_view_...
> > File chrome/renderer/print_web_view_helper_win.cc (left):
> > 
> >
>
http://codereview.chromium.org/6538048/diff/1/chrome/renderer/print_web_view_...
> > chrome/renderer/print_web_view_helper_win.cc:95:
> > page_params.metafile_data_handle = NULL;
> > Already initialized to INVALID_HANDLE_VALUE.
> 
> kmadhusu mentioned in person that we should keep it as NULL -> done in patch
set
> 2.

Expand Messages | Collapse Messages