Cleanup PrintWebViewHelper.

chrome/renderer/print_web_view_helper_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/print_web_view_helper.h"
 
 #include "base/logging.h"
 #include "base/process_util.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/render_messages_params.h"
-#include "chrome/renderer/render_view.h"
-#include "grit/generated_resources.h"
-#include "printing/native_metafile.h"
 #include "printing/units.h"
 #include "skia/ext/vector_canvas.h"
 #include "skia/ext/vector_platform_device.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "ui/gfx/gdi_util.h"
-#include "ui/gfx/size.h"
 
 using printing::ConvertUnitDouble;
 using printing::kPointsPerInch;
 using WebKit::WebFrame;
-using WebKit::WebString;
+
+namespace {
 
 int CALLBACK EnhMetaFileProc(HDC dc,
                              HANDLETABLE* handle_table,
                              const ENHMETARECORD *record,
                              int num_objects,
                              LPARAM data) {
   HDC* bitmap_dc = reinterpret_cast<HDC*>(data);
   // Play this command to the bitmap DC.
   PlayEnhMetaFileRecord(*bitmap_dc, handle_table, record, num_objects);
   if (record->iType == EMR_ALPHABLEND) {
@@ skipping 21 matching lines @@
     // Restore the world transforms of both DC's.
     SetWorldTransform(dc, &metafile_dc_transform);
     SetWorldTransform(*bitmap_dc, &bitmap_dc_transform);
   } else {
     // Play this command to the metafile DC.
     PlayEnhMetaFileRecord(dc, handle_table, record, num_objects);
   }
   return 1;  // Continue enumeration
 }
 
+}  // namespace
+
 void PrintWebViewHelper::PrintPage(const ViewMsg_PrintPage_Params& params,
                                    const gfx::Size& canvas_size,
                                    WebFrame* frame) {
   // Generate a memory-based metafile. It will use the current screen's DPI.
   // Each metafile contains a single page.
   scoped_ptr<printing::NativeMetafile> metafile(new printing::NativeMetafile);
   metafile->CreateDc(NULL, NULL);
   DCHECK(metafile->hdc());
   skia::PlatformDevice::InitializeDC(metafile->hdc());
 
   int page_number = params.page_number;
 
   // Calculate the dpi adjustment.
   float scale_factor = static_cast<float>(params.params.desired_dpi /
                                           params.params.dpi);
 
   // Render page for printing.
   RenderPage(params.params, &scale_factor, page_number, frame, &metafile);
 
   // Close the device context to retrieve the compiled metafile.
   if (!metafile->CloseDc())
     NOTREACHED();
 
   // Get the size of the compiled metafile.
   uint32 buf_size = metafile->GetDataSize();
   DCHECK_GT(buf_size, 128u);
 
   ViewHostMsg_DidPrintPage_Params page_params;
   page_params.data_size = buf_size;
-  page_params.metafile_data_handle = NULL;

[Lei Zhang, 2011/02/18 06:55:34]

Already initialized to INVALID_HANDLE_VALUE.

   page_params.page_number = page_number;
   page_params.document_cookie = params.params.document_cookie;
   page_params.actual_shrink = scale_factor;
   page_params.page_size = params.params.page_size;
   page_params.content_area = gfx::Rect(params.params.margin_left,
       params.params.margin_top, params.params.printable_size.width(),
       params.params.printable_size.height());
   page_params.has_visible_overlays = frame->isPageBoxVisible(page_number);
 
   if (!CopyMetafileDataToSharedMem(metafile.get(),
@@ skipping 56 matching lines @@
   if (!metafile->CloseDc())
     NOTREACHED();
 
   // Get the size of the compiled metafile.
   uint32 buf_size = metafile->GetDataSize();
   DCHECK_GT(buf_size, 128u);
 
   ViewHostMsg_DidPreviewDocument_Params preview_params;
   preview_params.document_cookie = params.params.document_cookie;
   preview_params.data_size = buf_size;
-  preview_params.metafile_data_handle = NULL;
 
   if (!CopyMetafileDataToSharedMem(metafile.get(),
                                    &(preview_params.metafile_data_handle))) {
     preview_params.data_size = 0;
   }
   metafile->CloseEmf();
   if (!Send(new ViewHostMsg_DuplicateSection(
           routing_id(),
           preview_params.metafile_data_handle,
           &preview_params.metafile_data_handle))) {
@@ skipping 71 matching lines @@
   if (platform_device->alpha_blend_used() && !params.supports_alpha_blend) {
     // Close the device context to retrieve the compiled metafile.
     if (!(*metafile)->CloseDc())
       NOTREACHED();
 
     scoped_ptr<printing::NativeMetafile> metafile2(
         new printing::NativeMetafile);
     // Page used alpha blend, but printer doesn't support it.  Rewrite the
     // metafile and flatten out the transparency.
     HDC bitmap_dc = CreateCompatibleDC(GetDC(NULL));
-    if (!bitmap_dc) {
+    if (!bitmap_dc)
       NOTREACHED() << "Bitmap DC creation failed";
-    }
     SetGraphicsMode(bitmap_dc, GM_ADVANCED);
     void* bits = NULL;
     BITMAPINFO hdr;
     gfx::CreateBitmapHeader(width, height, &hdr.bmiHeader);
     HBITMAP hbitmap = CreateDIBSection(
         bitmap_dc, &hdr, DIB_RGB_COLORS, &bits, NULL, 0);
-    if (!hbitmap) {
+    if (!hbitmap)
       NOTREACHED() << "Raster bitmap creation for printing failed";
-    }
 
     HGDIOBJ old_bitmap = SelectObject(bitmap_dc, hbitmap);
     RECT rect = {0, 0, width, height };
     HBRUSH whiteBrush = static_cast<HBRUSH>(GetStockObject(WHITE_BRUSH));
     FillRect(bitmap_dc, &rect, whiteBrush);
 
     metafile2->CreateDc(NULL, NULL);
     HDC hdc = metafile2->hdc();
     DCHECK(hdc);
     skia::PlatformDevice::InitializeDC(hdc);
@@ skipping 36 matching lines @@
   // Copy the bits into shared memory.
   if (!metafile->GetData(shared_buf.memory(), buf_size)) {
     NOTREACHED() << "GetData() failed";
     shared_buf.Unmap();
     return false;
   }
   shared_buf.GiveToProcess(base::GetCurrentProcessHandle(), shared_mem_handle);
   shared_buf.Unmap();
   return true;
 }