Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: chrome/browser/crash_handler_host_linux.h

Issue 6538033: Breakpad Linux: Fix crash handler writing to disk on the wrong thread.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/crash_handler_host_linux.h
===================================================================
--- chrome/browser/crash_handler_host_linux.h (revision 75308)
+++ chrome/browser/crash_handler_host_linux.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -6,17 +6,24 @@
#define CHROME_BROWSER_CRASH_HANDLER_HOST_LINUX_H_
#pragma once
+#include "base/message_loop.h"
+
+#if defined(USE_LINUX_BREAKPAD)
+#include <sys/types.h>
+
#include <string>
-#include "base/message_loop.h"
#include "base/scoped_ptr.h"
-template <typename T> struct DefaultSingletonTraits;
+class BreakpadInfo;
namespace base {
class Thread;
}
+#endif // defined(USE_LINUX_BREAKPAD)
+template <typename T> struct DefaultSingletonTraits;
+
// This is the base class for singleton objects which crash dump renderers and
// plugins on Linux. We perform the crash dump from the browser because it
// allows us to be outside the sandbox.
@@ -65,6 +72,15 @@
#if defined(USE_LINUX_BREAKPAD)
// This is here on purpose to make CrashHandlerHostLinux abstract.
virtual void SetProcessType() = 0;
+
+ // Do work on the FILE thread for OnFileCanReadWithoutBlocking().
+ void WriteDumpFile(BreakpadInfo* info,
+ pid_t crashing_pid,
+ char* crash_context,
+ int signal_fd);
+
+ // Continue OnFileCanReadWithoutBlocking()'s work on the IO thread.
+ void QueueCrashDumpTask(BreakpadInfo* info, int signal_fd);
#endif
int process_socket_;
« no previous file with comments | « no previous file | chrome/browser/crash_handler_host_linux.cc » ('j') | chrome/browser/crash_handler_host_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698