Breakpad Linux: Fix crash handler writing to disk on the wrong thread....

chrome/browser/crash_handler_host_linux.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CRASH_HANDLER_HOST_LINUX_H_
 #define CHROME_BROWSER_CRASH_HANDLER_HOST_LINUX_H_
 #pragma once
 
+#include "base/message_loop.h"
+
+#if defined(USE_LINUX_BREAKPAD)
+#include <sys/types.h>
+
 #include <string>
 
-#include "base/message_loop.h"
 #include "base/scoped_ptr.h"
 
-template <typename T> struct DefaultSingletonTraits;
+class BreakpadInfo;
 
 namespace base {
 class Thread;
 }
+#endif  // defined(USE_LINUX_BREAKPAD)
+
+template <typename T> struct DefaultSingletonTraits;
 
 // This is the base class for singleton objects which crash dump renderers and
 // plugins on Linux. We perform the crash dump from the browser because it
 // allows us to be outside the sandbox.
 //
 // PluginCrashHandlerHostLinux and RendererCrashHandlerHostLinux are singletons
 // that handle plugin and renderer crashes, respectively.
 //
 // Processes signal that they need to be dumped by sending a datagram over a
 // UNIX domain socket. All processes of the same type share the client end of
@@ skipping 29 matching lines @@
 
   std::string process_type_;
 #endif
 
  private:
   void Init();
 
 #if defined(USE_LINUX_BREAKPAD)
   // This is here on purpose to make CrashHandlerHostLinux abstract.
   virtual void SetProcessType() = 0;
+
+  // Do work on the FILE thread for OnFileCanReadWithoutBlocking().
+  void WriteDumpFile(BreakpadInfo* info,
+                     pid_t crashing_pid,
+                     char* crash_context,
+                     int signal_fd);
+
+  // Continue OnFileCanReadWithoutBlocking()'s work on the IO thread.
+  void QueueCrashDumpTask(BreakpadInfo* info, int signal_fd);
 #endif
 
   int process_socket_;
   int browser_socket_;
 
 #if defined(USE_LINUX_BREAKPAD)
   MessageLoopForIO::FileDescriptorWatcher file_descriptor_watcher_;
   scoped_ptr<base::Thread> uploader_thread_;
   bool shutting_down_;
 #endif
@@ skipping 46 matching lines @@
   virtual ~RendererCrashHandlerHostLinux();
 
 #if defined(USE_LINUX_BREAKPAD)
   virtual void SetProcessType();
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(RendererCrashHandlerHostLinux);
 };
 
 #endif  // CHROME_BROWSER_CRASH_HANDLER_HOST_LINUX_H_