Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 6538022: Switch the build over to using the base test runner to make sure... (Closed)

Created:
9 years, 10 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Switch the build over to using the base test runner to make sure base and ICU are started up right. BUG=72633 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75384

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/temp_gyp/googleurl.gyp View 1 2 3 4 2 chunks +5 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
TVL
the previous patch set passed the try bots, this new one is a whitespace cleanup, ...
9 years, 10 months ago (2011-02-17 21:24:34 UTC) #1
Robert Sesek
http://codereview.chromium.org/6538022/diff/5001/build/temp_gyp/googleurl.gyp File build/temp_gyp/googleurl.gyp (right): http://codereview.chromium.org/6538022/diff/5001/build/temp_gyp/googleurl.gyp#newcode74 build/temp_gyp/googleurl.gyp:74: '../../base/base.gyp:test_support_base', Was the issue here missing symbols that was ...
9 years, 10 months ago (2011-02-17 21:44:22 UTC) #2
TVL
http://codereview.chromium.org/6538022/diff/5001/build/temp_gyp/googleurl.gyp File build/temp_gyp/googleurl.gyp (right): http://codereview.chromium.org/6538022/diff/5001/build/temp_gyp/googleurl.gyp#newcode74 build/temp_gyp/googleurl.gyp:74: '../../base/base.gyp:test_support_base', On 2011/02/17 21:44:22, rsesek wrote: > Was the ...
9 years, 10 months ago (2011-02-17 21:52:51 UTC) #3
Robert Sesek
9 years, 10 months ago (2011-02-17 22:02:08 UTC) #4
Ok. LGTM.

Powered by Google App Engine
This is Rietveld 408576698